Description
In the Linux kernel, the following vulnerability has been resolved: qlcnic: prevent ->dcb use-after-free on qlcnic_dcb_enable() failure adapter->dcb would get silently freed inside qlcnic_dcb_enable() in case qlcnic_dcb_attach() would return an error, which always happens under OOM conditions. This would lead to use-after-free because both of the existing callers invoke qlcnic_dcb_get_info() on the obtained pointer, which is potentially freed at that point. Propagate errors from qlcnic_dcb_enable(), and instead free the dcb pointer at callsite using qlcnic_dcb_free(). This also removes the now unused qlcnic_clear_dcb_ops() helper, which was a simple wrapper around kfree() also causing memory leaks for partially initialized dcb. Found by Linux Verification Center (linuxtesting.org) with the SVACE static analysis tool.
Product status
3c44bba1d270cb1620b4fe76786d0968118cb86b (git) before 36999236f0b12d5de21a6f40e93b570727b9ceb2
3c44bba1d270cb1620b4fe76786d0968118cb86b (git) before d12a7510293d3370b234b0b7c5eda33e58786768
3c44bba1d270cb1620b4fe76786d0968118cb86b (git) before 8f97eeb02a553cdc78c83a0596448a370e1518c4
3c44bba1d270cb1620b4fe76786d0968118cb86b (git) before 513787ff9a331b461115e8a145a983d650a84fcb
3c44bba1d270cb1620b4fe76786d0968118cb86b (git) before 95df720e64a6409d8152827a776c43f615e3321a
3c44bba1d270cb1620b4fe76786d0968118cb86b (git) before 8df1dc04ce0e4c03b51a756749c250a9cb17d707
3c44bba1d270cb1620b4fe76786d0968118cb86b (git) before a2a694e6edbdb3efb34e1613a31fdcf6cf444a55
3c44bba1d270cb1620b4fe76786d0968118cb86b (git) before 13a7c8964afcd8ca43c0b6001ebb0127baa95362
3.14
Any version before 3.14
4.14.303 (semver)
4.19.270 (semver)
5.4.229 (semver)
5.10.163 (semver)
5.15.87 (semver)
6.0.19 (semver)
6.1.5 (semver)
6.2 (original_commit_for_fix)
References
git.kernel.org/...c/36999236f0b12d5de21a6f40e93b570727b9ceb2
git.kernel.org/...c/d12a7510293d3370b234b0b7c5eda33e58786768
git.kernel.org/...c/8f97eeb02a553cdc78c83a0596448a370e1518c4
git.kernel.org/...c/513787ff9a331b461115e8a145a983d650a84fcb
git.kernel.org/...c/95df720e64a6409d8152827a776c43f615e3321a
git.kernel.org/...c/8df1dc04ce0e4c03b51a756749c250a9cb17d707
git.kernel.org/...c/a2a694e6edbdb3efb34e1613a31fdcf6cf444a55
git.kernel.org/...c/13a7c8964afcd8ca43c0b6001ebb0127baa95362