Description
In the Linux kernel, the following vulnerability has been resolved: net: ethernet: ti: Fix return type of netcp_ndo_start_xmit() With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP attacks. If they are not identical, there is a failure at run time, which manifests as either a kernel panic or thread getting killed. A proposed warning in clang aims to catch these at compile time, which reveals: drivers/net/ethernet/ti/netcp_core.c:1944:21: error: incompatible function pointer types initializing 'netdev_tx_t (*)(struct sk_buff *, struct net_device *)' (aka 'enum netdev_tx (*)(struct sk_buff *, struct net_device *)') with an expression of type 'int (struct sk_buff *, struct net_device *)' [-Werror,-Wincompatible-function-pointer-types-strict] .ndo_start_xmit = netcp_ndo_start_xmit, ^~~~~~~~~~~~~~~~~~~~ 1 error generated. ->ndo_start_xmit() in 'struct net_device_ops' expects a return type of 'netdev_tx_t', not 'int'. Adjust the return type of netcp_ndo_start_xmit() to match the prototype's to resolve the warning and CFI failure.
Product status
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 before a447479ea2cf35603b5739ea947885024b901222
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 before 17bb9bdf701f3e811a9f4820b08b9538ade2641c
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 before d837d74eae077cc3ef9e191ba8535b5f602d4673
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 before dbe1a6b930ae9647e8ce0b684c903ac67d4398eb
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 before 5b0b6553bf4ad3a435a57e02c68d6075f384e1be
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 before a413ebb6049edd881c6427cfa25a7efddd6a4f74
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 before 765636e58ba505cfe4927eda7ee83791b1c6402a
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 before 1e4953b826e12b31995564a459dbd4e9e4604a35
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 before 63fe6ff674a96cfcfc0fa8df1051a27aa31c70b4
4.9.337
4.14.303
4.19.270
5.4.229
5.10.163
5.15.86
6.0.16
6.1.2
6.2
References
git.kernel.org/...c/a447479ea2cf35603b5739ea947885024b901222
git.kernel.org/...c/17bb9bdf701f3e811a9f4820b08b9538ade2641c
git.kernel.org/...c/d837d74eae077cc3ef9e191ba8535b5f602d4673
git.kernel.org/...c/dbe1a6b930ae9647e8ce0b684c903ac67d4398eb
git.kernel.org/...c/5b0b6553bf4ad3a435a57e02c68d6075f384e1be
git.kernel.org/...c/a413ebb6049edd881c6427cfa25a7efddd6a4f74
git.kernel.org/...c/765636e58ba505cfe4927eda7ee83791b1c6402a
git.kernel.org/...c/1e4953b826e12b31995564a459dbd4e9e4604a35
git.kernel.org/...c/63fe6ff674a96cfcfc0fa8df1051a27aa31c70b4