Description
In the Linux kernel, the following vulnerability has been resolved: s390/netiucv: Fix return type of netiucv_tx() With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP attacks. If they are not identical, there is a failure at run time, which manifests as either a kernel panic or thread getting killed. A proposed warning in clang aims to catch these at compile time, which reveals: drivers/s390/net/netiucv.c:1854:21: error: incompatible function pointer types initializing 'netdev_tx_t (*)(struct sk_buff *, struct net_device *)' (aka 'enum netdev_tx (*)(struct sk_buff *, struct net_device *)') with an expression of type 'int (struct sk_buff *, struct net_device *)' [-Werror,-Wincompatible-function-pointer-types-strict] .ndo_start_xmit = netiucv_tx, ^~~~~~~~~~ ->ndo_start_xmit() in 'struct net_device_ops' expects a return type of 'netdev_tx_t', not 'int'. Adjust the return type of netiucv_tx() to match the prototype's to resolve the warning and potential CFI failure, should s390 select ARCH_SUPPORTS_CFI_CLANG in the future. Additionally, while in the area, remove a comment block that is no longer relevant.
Product status
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before f13d870fce90f01cf930bfaffecc8185ae0be21c
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before eccc88c0efe407e579291792ad07a7dedc0f63f0
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 85d392710275355425df8618ccbebbc336f5acc5
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 4bee3c75d5bf7c2b5dc0b520410eb40449e5da31
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 3ac0217ca9186c2f9af9a0113a331a42aa847894
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before dfbf0122ea1b9b3e73fa22c8ff6bd888935c54fc
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before e7a849f740e3576e79cba403697e916f4c3a6f12
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before d034fa43af92fc46a81d882f46d9cc3e4ffdbbcc
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 88d86d18d7cf7e9137c95f9d212bb9fff8a1b4be
4.9.337 (semver)
4.14.303 (semver)
4.19.270 (semver)
5.4.229 (semver)
5.10.163 (semver)
5.15.86 (semver)
6.0.16 (semver)
6.1.2 (semver)
6.2 (original_commit_for_fix)
References
git.kernel.org/...c/f13d870fce90f01cf930bfaffecc8185ae0be21c
git.kernel.org/...c/eccc88c0efe407e579291792ad07a7dedc0f63f0
git.kernel.org/...c/85d392710275355425df8618ccbebbc336f5acc5
git.kernel.org/...c/4bee3c75d5bf7c2b5dc0b520410eb40449e5da31
git.kernel.org/...c/3ac0217ca9186c2f9af9a0113a331a42aa847894
git.kernel.org/...c/dfbf0122ea1b9b3e73fa22c8ff6bd888935c54fc
git.kernel.org/...c/e7a849f740e3576e79cba403697e916f4c3a6f12
git.kernel.org/...c/d034fa43af92fc46a81d882f46d9cc3e4ffdbbcc
git.kernel.org/...c/88d86d18d7cf7e9137c95f9d212bb9fff8a1b4be
