CVE-2025-38348
wifi: p54: prevent buffer-overflow in p54_rx_eeprom_readback()
We use these services and cookies to improve your user experience. You may opt out if you wish, however, this may limit some features on this site.
Please see our statement on Data Privacy.
wifi: p54: prevent buffer-overflow in p54_rx_eeprom_readback()
In the Linux kernel, the following vulnerability has been resolved: wifi: p54: prevent buffer-overflow in p54_rx_eeprom_readback() Robert Morris reported: |If a malicious USB device pretends to be an Intersil p54 wifi |interface and generates an eeprom_readback message with a large |eeprom->v1.len, p54_rx_eeprom_readback() will copy data from the |message beyond the end of priv->eeprom. | |static void p54_rx_eeprom_readback(struct p54_common *priv, | struct sk_buff *skb) |{ | struct p54_hdr *hdr = (struct p54_hdr *) skb->data; | struct p54_eeprom_lm86 *eeprom = (struct p54_eeprom_lm86 *) hdr->data; | | if (priv->fw_var >= 0x509) { | memcpy(priv->eeprom, eeprom->v2.data, | le16_to_cpu(eeprom->v2.len)); | } else { | memcpy(priv->eeprom, eeprom->v1.data, | le16_to_cpu(eeprom->v1.len)); | } | [...] The eeprom->v{1,2}.len is set by the driver in p54_download_eeprom(). The device is supposed to provide the same length back to the driver. But yes, it's possible (like shown in the report) to alter the value to something that causes a crash/panic due to overrun. This patch addresses the issue by adding the size to the common device context, so p54_rx_eeprom_readback no longer relies on possibly tampered values... That said, it also checks if the "firmware" altered the value and no longer copies them. The one, small saving grace is: Before the driver tries to read the eeprom, it needs to upload >a< firmware. the vendor firmware has a proprietary license and as a reason, it is not present on most distributions by default.
Reserved 2025-04-16 | Published 2025-07-10 | Updated 2025-07-10 | Assigner Linuxgit.kernel.org/...c/12134f79e53eb56b0b0b7447fa0c512acf6a8422
git.kernel.org/...c/9701f842031b825e2fd5f22d064166f8f13f6e4d
git.kernel.org/...c/1f7f8168abe8cbe845ab8bb557228d44784a6b57
git.kernel.org/...c/f39b2f8c1549a539846e083790fad396ef6cd802
git.kernel.org/...c/0e4dc150423b829c35cbcf399481ca11594fc036
git.kernel.org/...c/6d05390d20f110de37d051a3e063ef0a542d01fb
git.kernel.org/...c/714afb4c38edd19a057d519c1f9c5d164b43de94
git.kernel.org/...c/da1b9a55ff116cb040528ef664c70a4eec03ae99
Support options
