Description
In the Linux kernel, the following vulnerability has been resolved: drbd: add missing kref_get in handle_write_conflicts With `two-primaries` enabled, DRBD tries to detect "concurrent" writes and handle write conflicts, so that even if you write to the same sector simultaneously on both nodes, they end up with the identical data once the writes are completed. In handling "superseeded" writes, we forgot a kref_get, resulting in a premature drbd_destroy_device and use after free, and further to kernel crashes with symptoms. Relevance: No one should use DRBD as a random data generator, and apparently all users of "two-primaries" handle concurrent writes correctly on layer up. That is cluster file systems use some distributed lock manager, and live migration in virtualization environments stops writes on one node before starting writes on the other node. Which means that other than for "test cases", this code path is never taken in real life. FYI, in DRBD 9, things are handled differently nowadays. We still detect "write conflicts", but no longer try to be smart about them. We decided to disconnect hard instead: upper layers must not submit concurrent writes. If they do, that's their fault.
Product status
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 0336bfe9c237476bd7c45605a36ca79c2bca62e5
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 810cd546a29bfac90ed1328ea01d693d4bd11cb1
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 84ef8dd3238330d1795745ece83b19f0295751bf
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 57418de35420cedab035aa1da8a26c0499b7f575
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 9f53b2433ad248cd3342cc345f56f5c7904bd8c4
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 7d483ad300fc0a06f69b019dda8f74970714baf8
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 46e3763dcae0ffcf8fcfaff4fc10a90a92ffdd89
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 3a896498f6f577e57bf26aaa93b48c22b6d20c20
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 00c9c9628b49e368d140cfa61d7df9b8922ec2a8
5.4.297 (semver)
5.10.241 (semver)
5.15.190 (semver)
6.1.149 (semver)
6.6.103 (semver)
6.12.43 (semver)
6.15.11 (semver)
6.16.2 (semver)
6.17 (original_commit_for_fix)
References
git.kernel.org/...c/0336bfe9c237476bd7c45605a36ca79c2bca62e5
git.kernel.org/...c/810cd546a29bfac90ed1328ea01d693d4bd11cb1
git.kernel.org/...c/84ef8dd3238330d1795745ece83b19f0295751bf
git.kernel.org/...c/57418de35420cedab035aa1da8a26c0499b7f575
git.kernel.org/...c/9f53b2433ad248cd3342cc345f56f5c7904bd8c4
git.kernel.org/...c/7d483ad300fc0a06f69b019dda8f74970714baf8
git.kernel.org/...c/46e3763dcae0ffcf8fcfaff4fc10a90a92ffdd89
git.kernel.org/...c/3a896498f6f577e57bf26aaa93b48c22b6d20c20
git.kernel.org/...c/00c9c9628b49e368d140cfa61d7df9b8922ec2a8
