Description
In the Linux kernel, the following vulnerability has been resolved: bpf: Forget ranges when refining tnum after JSET Syzbot reported a kernel warning due to a range invariant violation on the following BPF program. 0: call bpf_get_netns_cookie 1: if r0 == 0 goto <exit> 2: if r0 & Oxffffffff goto <exit> The issue is on the path where we fall through both jumps. That path is unreachable at runtime: after insn 1, we know r0 != 0, but with the sign extension on the jset, we would only fallthrough insn 2 if r0 == 0. Unfortunately, is_branch_taken() isn't currently able to figure this out, so the verifier walks all branches. The verifier then refines the register bounds using the second condition and we end up with inconsistent bounds on this unreachable path: 1: if r0 == 0 goto <exit> r0: u64=[0x1, 0xffffffffffffffff] var_off=(0, 0xffffffffffffffff) 2: if r0 & 0xffffffff goto <exit> r0 before reg_bounds_sync: u64=[0x1, 0xffffffffffffffff] var_off=(0, 0) r0 after reg_bounds_sync: u64=[0x1, 0] var_off=(0, 0) Improving the range refinement for JSET to cover all cases is tricky. We also don't expect many users to rely on JSET given LLVM doesn't generate those instructions. So instead of improving the range refinement for JSETs, Eduard suggested we forget the ranges whenever we're narrowing tnums after a JSET. This patch implements that approach.
Product status
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before f01e06930444cab289a8783017af9b64255bd103
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 2fd0c26bacd90ef26522bd3169000a4715bf151f
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 80a6b11862a7cfdf691e8f9faee89cfea219f098
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 6279846b9b2532e1b04559ef8bd0dec049f29383
6.12.43 (semver)
6.15.11 (semver)
6.16.2 (semver)
6.17 (original_commit_for_fix)
References
git.kernel.org/...c/f01e06930444cab289a8783017af9b64255bd103
git.kernel.org/...c/2fd0c26bacd90ef26522bd3169000a4715bf151f
git.kernel.org/...c/80a6b11862a7cfdf691e8f9faee89cfea219f098
git.kernel.org/...c/6279846b9b2532e1b04559ef8bd0dec049f29383
