Description
In the Linux kernel, the following vulnerability has been resolved: btrfs: qgroup: fix race between quota disable and quota rescan ioctl There's a race between a task disabling quotas and another running the rescan ioctl that can result in a use-after-free of qgroup records from the fs_info->qgroup_tree rbtree. This happens as follows: 1) Task A enters btrfs_ioctl_quota_rescan() -> btrfs_qgroup_rescan(); 2) Task B enters btrfs_quota_disable() and calls btrfs_qgroup_wait_for_completion(), which does nothing because at that point fs_info->qgroup_rescan_running is false (it wasn't set yet by task A); 3) Task B calls btrfs_free_qgroup_config() which starts freeing qgroups from fs_info->qgroup_tree without taking the lock fs_info->qgroup_lock; 4) Task A enters qgroup_rescan_zero_tracking() which starts iterating the fs_info->qgroup_tree tree while holding fs_info->qgroup_lock, but task B is freeing qgroup records from that tree without holding the lock, resulting in a use-after-free. Fix this by taking fs_info->qgroup_lock at btrfs_free_qgroup_config(). Also at btrfs_qgroup_rescan() don't start the rescan worker if quotas were already disabled.
Product status
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 7cda0fdde5d9890976861421d207870500f9aace
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before b172535ccba12f0cf7d23b3b840989de47fc104d
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before dd0b28d877b293b1d7f8727a7de08ae36b6b9ef0
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before c38028ce0d0045ca600b6a8345a0ff92bfb47b66
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before 2fd0f5ceb997f90f4332ccbab6c7e907e6b2d0eb
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (git) before e1249667750399a48cafcf5945761d39fa584edf
6.1.149 (semver)
6.6.103 (semver)
6.12.44 (semver)
6.15.11 (semver)
6.16.2 (semver)
6.17 (original_commit_for_fix)
References
git.kernel.org/...c/7cda0fdde5d9890976861421d207870500f9aace
git.kernel.org/...c/b172535ccba12f0cf7d23b3b840989de47fc104d
git.kernel.org/...c/dd0b28d877b293b1d7f8727a7de08ae36b6b9ef0
git.kernel.org/...c/c38028ce0d0045ca600b6a8345a0ff92bfb47b66
git.kernel.org/...c/2fd0f5ceb997f90f4332ccbab6c7e907e6b2d0eb
git.kernel.org/...c/e1249667750399a48cafcf5945761d39fa584edf