Description
In the Linux kernel, the following vulnerability has been resolved: xfs: do not propagate ENODATA disk errors into xattr code ENODATA (aka ENOATTR) has a very specific meaning in the xfs xattr code; namely, that the requested attribute name could not be found. However, a medium error from disk may also return ENODATA. At best, this medium error may escape to userspace as "attribute not found" when in fact it's an IO (disk) error. At worst, we may oops in xfs_attr_leaf_get() when we do: error = xfs_attr_leaf_hasname(args, &bp); if (error == -ENOATTR) { xfs_trans_brelse(args->trans, bp); return error; } because an ENODATA/ENOATTR error from disk leaves us with a null bp, and the xfs_trans_brelse will then null-deref it. As discussed on the list, we really need to modify the lower level IO functions to trap all disk errors and ensure that we don't let unique errors like this leak up into higher xfs functions - many like this should be remapped to EIO. However, this patch directly addresses a reported bug in the xattr code, and should be safe to backport to stable kernels. A larger-scope patch to handle more unique errors at lower levels can follow later. (Note, prior to 07120f1abdff we did not oops, but we did return the wrong error code to userspace.)
Product status
07120f1abdff80f3d1351f733661abe28d609535 (git) before 157ddfb05961c68ab7d457a462822a698e4e4bf4
07120f1abdff80f3d1351f733661abe28d609535 (git) before 90bae69c2959c39912f0c2f07a9a7894f3fc49f5
07120f1abdff80f3d1351f733661abe28d609535 (git) before e358d4b6225e4c1eb208686a05e360ef8df59e07
07120f1abdff80f3d1351f733661abe28d609535 (git) before d3cc7476b89fb45b7e00874f4f56f6b928467c60
07120f1abdff80f3d1351f733661abe28d609535 (git) before dcdf36f1b67884c722abce9b8946e34ffb9f67c8
07120f1abdff80f3d1351f733661abe28d609535 (git) before 39fc2742ca14f7fbc621ce9b43bcbd00248cb9a8
07120f1abdff80f3d1351f733661abe28d609535 (git) before ae668cd567a6a7622bc813ee0bb61c42bed61ba7
5.9
Any version before 5.9
5.10.242 (semver)
5.15.191 (semver)
6.1.150 (semver)
6.6.104 (semver)
6.12.45 (semver)
6.16.5 (semver)
6.17 (original_commit_for_fix)
References
git.kernel.org/...c/157ddfb05961c68ab7d457a462822a698e4e4bf4
git.kernel.org/...c/90bae69c2959c39912f0c2f07a9a7894f3fc49f5
git.kernel.org/...c/e358d4b6225e4c1eb208686a05e360ef8df59e07
git.kernel.org/...c/d3cc7476b89fb45b7e00874f4f56f6b928467c60
git.kernel.org/...c/dcdf36f1b67884c722abce9b8946e34ffb9f67c8
git.kernel.org/...c/39fc2742ca14f7fbc621ce9b43bcbd00248cb9a8
git.kernel.org/...c/ae668cd567a6a7622bc813ee0bb61c42bed61ba7