Description
ImpactWhen an application passes user-controlled input to the upgrade option of client.request(), an attacker can inject CRLF sequences (\r\n) to: * Inject arbitrary HTTP headers * Terminate the HTTP request prematurely and smuggle raw data to non-HTTP services (Redis, Memcached, Elasticsearch) The vulnerability exists because undici writes the upgrade value directly to the socket without validating for invalid header characters: // lib/dispatcher/client-h1.js:1121 if (upgrade) { header += `connection: upgrade\r\nupgrade: ${upgrade}\r\n` }
Problem types
CWE-93 Improper neutralization of CRLF sequences ('CRLF injection')
Product status
< 6.24.0; 7.0.0 < 7.24.0
6.24.0: 7.24.0
Credits
Matteo Collina
Ulises Gascón
Raul Vega del Valle
References
github.com/...undici/security/advisories/GHSA-4992-7rv2-5pvq
cna.openjsf.org/security-advisories.html