Description
In the Linux kernel, the following vulnerability has been resolved: tls: Purge async_hold in tls_decrypt_async_wait() The async_hold queue pins encrypted input skbs while the AEAD engine references their scatterlist data. Once tls_decrypt_async_wait() returns, every AEAD operation has completed and the engine no longer references those skbs, so they can be freed unconditionally. A subsequent patch adds batch async decryption to tls_sw_read_sock(), introducing a new call site that must drain pending AEAD operations and release held skbs. Move __skb_queue_purge(&ctx->async_hold) into tls_decrypt_async_wait() so the purge is centralized and every caller -- recvmsg's drain path, the -EBUSY fallback in tls_do_decryption(), and the new read_sock batch path -- releases held skbs on synchronization without each site managing the purge independently. This fixes a leak when tls_strp_msg_hold() fails part-way through, after having added some cloned skbs to the async_hold queue. tls_decrypt_sg() will then call tls_decrypt_async_wait() to process all pending decrypts, and drop back to synchronous mode, but tls_sw_recvmsg() only flushes the async_hold queue when one record has been processed in "fully-async" mode, which may not be the case here. [pabeni@redhat.com: added leak comment]
Product status
9f83fd0c179e0f458e824e417f9d5ad53443f685 (git) before ac435be7c7613eb13a5a8ceb5182e10b50c9ce87
c61d4368197d65c4809d9271f3b85325a600586a (git) before 2dcf324855c34e7f934ce978aa19b645a8f3ee71
39dec4ea3daf77f684308576baf483b55ca7f160 (git) before 6dc11e0bd0a5466bcc76d275c09e5537bd0597dd
b8a6ff84abbcbbc445463de58704686011edc8e1 (git) before 9f557c7eae127b44d2e863917dc986a4b6cb1269
b8a6ff84abbcbbc445463de58704686011edc8e1 (git) before fd8037e1f18ca5336934d0e0e7e1a4fe097e749d
b8a6ff84abbcbbc445463de58704686011edc8e1 (git) before 84a8335d8300576f1b377ae24abca1d9f197807f
4fc109d0ab196bd943b7451276690fb6bb48c2e0 (git)
6.1.158 (semver) before 6.1.168
6.6.114 (semver) before 6.6.131
6.12.55 (semver) before 6.12.80
6.17.5 (semver) before 6.18
6.18
Any version before 6.18
6.1.168 (semver)
6.6.131 (semver)
6.12.80 (semver)
6.18.21 (semver)
6.19.11 (semver)
7.0 (original_commit_for_fix)
References
git.kernel.org/...c/ac435be7c7613eb13a5a8ceb5182e10b50c9ce87
git.kernel.org/...c/2dcf324855c34e7f934ce978aa19b645a8f3ee71
git.kernel.org/...c/6dc11e0bd0a5466bcc76d275c09e5537bd0597dd
git.kernel.org/...c/9f557c7eae127b44d2e863917dc986a4b6cb1269
git.kernel.org/...c/fd8037e1f18ca5336934d0e0e7e1a4fe097e749d
git.kernel.org/...c/84a8335d8300576f1b377ae24abca1d9f197807f