Description
FreeRDP is a free implementation of the Remote Desktop Protocol. Prior to 3.24.0, division by zero in MS-ADPCM and IMA-ADPCM decoders when nBlockAlign is 0, leading to a crash. In libfreerdp/codec/dsp.c, both ADPCM decoders use size % block_size where block_size = context->common.format.nBlockAlign. The nBlockAlign value comes from the Server Audio Formats PDU on the RDPSND channel. The value 0 is not validated anywhere before reaching the decoder. When nBlockAlign = 0, the modulo operation causes a SIGFPE (floating point exception) crash. This vulnerability is fixed in 3.24.0.
Problem types
Product status
References
github.com/...reeRDP/security/advisories/GHSA-jp7m-94ww-p56r
github.com/...ommit/03b48b3601d867afccac1cdc6081de7a275edce7
github.com/...ommit/16df2300e1e3f5a51f68fb1626429e58b531b7c8