Description
Vikunja is an open-source self-hosted task management platform. Prior to 2.3.0, the TOTP failed-attempt lockout mechanism is non-functional due to a database transaction handling bug. When a TOTP validation fails, the login handler in pkg/routes/api/v1/login.go calls HandleFailedTOTPAuth and then unconditionally rolls back. HandleFailedTOTPAuth in pkg/user/totp.go uses an in-memory counter (key-value store) to track failed attempts. When the counter reaches 10, it calls user.SetStatus(s, StatusAccountLocked) on the same database session s. Because the login handler always rolls back after a TOTP failure, the StatusAccountLocked write is undone. The in-memory counter correctly increments past 10, so the lockout code executes on every subsequent attempt, but the database write is rolled back every time. This allows unlimited brute-force attempts against TOTP codes. This vulnerability is fixed in 2.3.0.
Problem types
CWE-307: Improper Restriction of Excessive Authentication Attempts
Product status
References
github.com/...ikunja/security/advisories/GHSA-fgfv-pv97-6cmj
github.com/...ikunja/security/advisories/GHSA-fgfv-pv97-6cmj
github.com/go-vikunja/vikunja/pull/2576
github.com/...ommit/6ca0151d02fa0e8c7e2181ab916a28e08caaaec8
github.com/go-vikunja/vikunja/releases/tag/v2.3.0