Description
nimiq-blockchain provides persistent block storage for Nimiq's Rust implementation. In versions 1.3.0 and below, a malicious network peer can crash any Nimiq full node by publishing a crafted Kademlia DHT record. The maliciously crafted record would contain a TaggedSigned<ValidatorRecord, KeyPair> with a signature field whose byte length is not exactly 64 in order to cause a crash. When the victim node's DHT verifier calls TaggedSigned::verify, execution reaches Ed25519Signature::from_bytes(sig).unwrap() in the TaggedPublicKey implementation for Ed25519PublicKey. The from_bytes call fails because ed25519_zebra::Signature::try_from rejects slices not 64 bytes, and the unwrap() panics. The BLS TaggedPublicKey implementation correctly returns false on error; only the Ed25519 implementation panics. This issue has been fixed in version 1.4.0.
Problem types
CWE-252: Unchecked Return Value
Product status
References
github.com/...atross/security/advisories/GHSA-27w2-87xv-37c6
github.com/nimiq/core-rs-albatross/pull/3708
github.com/...ommit/807ee8e99a7ccdc604d49971f292854bfa36754d
github.com/nimiq/core-rs-albatross/releases/tag/v1.4.0