Description
Impact: The fix for CVE-2021-23337 (https://github.com/advisories/GHSA-35jh-r3h4-6jhm) added validation for the variable option in _.template but did not apply the same validation to options.imports key names. Both paths flow into the same Function() constructor sink. When an application passes untrusted input as options.imports key names, an attacker can inject default-parameter expressions that execute arbitrary code at template compilation time. Additionally, _.template uses assignInWith to merge imports, which enumerates inherited properties via for..in. If Object.prototype has been polluted by any other vector, the polluted keys are copied into the imports object and passed to Function(). Patches: Users should upgrade to version 4.18.0. Workarounds: Do not pass untrusted input as key names in options.imports. Only use developer-controlled, static key names.
Problem types
CWE-94: Improper Control of Generation of Code ('Code Injection')
Product status
4.0.0 (semver) before 4.18.0
4.18.0 (semver)
4.0.0 (semver) before 4.18.0
4.18.0 (semver)
4.0.0 (semver) before 4.18.0
4.18.0 (semver)
4.0.0 (semver) before 4.18.0
4.18.0 (semver)
Credits
dolevmiz1
bugbunny-research
M0nd0R
UlisesGascon
falsyvalues
jonchurch
threalwinky
jdalton
References
github.com/advisories/GHSA-35jh-r3h4-6jhm
github.com/...ommit/3469357cff396a26c363f8c1b5a91dde28ba4b1c
cna.openjsf.org/security-advisories.html